fix(mutation): drop unsupported --thresholds.break from per-file #91
Merged
Conversation
…ker args The batched runner passed `--thresholds.break 0` to each per-file `stryker run`. Stryker 9.x removed dot-notation CLI options, so every per-file run failed with `error: unknown option '--thresholds.break'`, produced no report, and failed the mutation CI job on the first file. The flag was unnecessary: a per-file run dropping below the configured break threshold is expected and already caught by the runner, which gates on the aggregate score. Remove the flag and assert its absence.
|
Build artifact for this PR: |
goanpeca
added
tech-debt
There was a problem hiding this comment.
Pull request overview
This PR updates the batched Stryker mutation runner to stop passing the now-unsupported --thresholds.break dot-notation CLI flag (removed in Stryker 9.x), and adjusts the accompanying unit test to assert the flag is not present.
Changes:
- Remove
--thresholds.break 0from per-filestryker runinvocations in the batched mutation runner. - Update the batched mutation runner test to assert
--thresholds.breakis not passed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/run-batched-mutation-lib.mjs | Drops the unsupported --thresholds.break CLI arg from the per-file Stryker command. |
| tests/run-batched-mutation.test.ts | Updates assertions/comments to reflect the removed --thresholds.break arg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build artifact for this PR: |
goanpeca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--thresholds.breakCLI option from per-filestryker runinvocations for Stryker 9.x.thresholds.break: null, the single mutate target, and the wrapper-owned reporters so individual files do not fail the job solely for being below the break threshold.thresholds.breakfromstryker.conf.json, while still failing hard child failures, errored mutants, and unknown mutant statuses.Testing
pnpm exec vitest run __tests__/run-batched-mutation.test.tspnpm typecheckpnpm lintpnpm testNotes for reviewers
src/anddist/are unchanged; this PR only changes the batched mutation runner script and its tests.